-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-formatting parser output #3919
Re-formatting parser output #3919
Conversation
Making parsing messages when loading/reloading scripts looks better and much easier to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! Just a few minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, this may already be possible (let me know if it is) but I'd like users to be able to change the colour codes of the message - some of the red and grey text may be difficult for some users to read, and they may want to change it to a more visible colour.
I know it's possible in the english.lang
file to edit this, but I think this file is not easily accessible to the user.
As discussed on discord, I would also suggest improve updating language files by users since that is what it should be. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I agree that adding a bunch of config options would be too much, but I wonder if it would be worthwhile to just add a single |
This might be nice, but I think ought to be its own PR and apply to all Skript system messages. |
This could be a good option so users don't necessarily have to edit the lang files. However, I think it would also be a good idea to be able to reload the lang files in game so users can customize in that manner. We include lang files by default now after the overhaul by TP, so I think reloading would be the next best step. |
Thanks to @TPGamesNL for SkriptCommand.java changes
All requested changes have been done.
I really agree on this and I have added a support for that but if there are any notes/suggestions about how I did it let me know. |
Description
Making parsing messages when loading/reloading scripts looks better and much easier to read
How it looks
How it looks in-game (outdated)
How it looks in console (highly depends on the terminal theme used, mine was gray which is eye hurting)
Target Minecraft Versions:
Requirements:
Related Issues: #3505